fix(preprod): Add timeout to build upload polling loop#3118
Merged
NicoHinderling merged 2 commits intomasterfrom Jan 30, 2026
Merged
fix(preprod): Add timeout to build upload polling loop#3118NicoHinderling merged 2 commits intomasterfrom
NicoHinderling merged 2 commits intomasterfrom
Conversation
The polling loop in `build upload` could infinite loop when the server returns a pending state (Created/Assembling) without an artifact_url. Add a 5-minute timeout and 1-second sleep between iterations, matching the pattern used in the existing poll_assemble function. Fixes #2942 Co-Authored-By: Claude <noreply@anthropic.com>
NicoHinderling
changed the title
rbro112
approved these changes
Jan 30, 2026
szokeasaurusrex
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polling loop in
build uploadcould infinite loop when the server returns a pending state (CreatedorAssembling) without ever providing anartifact_url. The loop only exited on:artifact_urlbeing set (success)state == Error(error bail)state.is_finished()which only matchesOkorErrorStates like
Created,Assembling, andNotFoundare NOTis_finished(), causing infinite polling if the server misbehaves.This adds a 5-minute timeout (
DEFAULT_MAX_WAIT) and 1-second sleep (ASSEMBLE_POLL_INTERVAL) between iterations, matching the existing pattern insrc/utils/chunks/upload.rs:poll_assemble.Fixes #2942
Closes EME-626